Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cover all possible generic components with accessibility identifiers #517

Merged
merged 6 commits into from
Sep 24, 2018
Merged

Cover all possible generic components with accessibility identifiers #517

merged 6 commits into from
Sep 24, 2018

Conversation

dive
Copy link
Member

@dive dive commented Sep 24, 2018

No description provided.

@codecov-io
Copy link

codecov-io commented Sep 24, 2018

Codecov Report

Merging #517 into master will increase coverage by 0.05%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #517      +/-   ##
==========================================
+ Coverage    64.6%   64.65%   +0.05%     
==========================================
  Files          76       76              
  Lines        3910     3919       +9     
==========================================
+ Hits         2526     2534       +8     
- Misses       1384     1385       +1
Impacted Files Coverage Δ
...at Items/PhotoMessages/PhotoMessageViewModel.swift 80.95% <ø> (ø) ⬆️
...Chat Items/TextMessages/TextMessageViewModel.swift 87.5% <ø> (ø) ⬆️
...dditions/Source/Input/ChatInputBarAppearance.swift 100% <ø> (ø) ⬆️
...hotos/Placeholder/PhotosInputPlaceholderCell.swift 0% <0%> (ø) ⬆️
...essages/Views/PhotoMessageCollectionViewCell.swift 100% <100%> (ø) ⬆️
ChattoAdditions/Source/Input/ChatInputBar.swift 74% <100%> (+0.35%) ⬆️
...Chat Items/TextMessages/Views/TextBubbleView.swift 74.3% <100%> (+0.14%) ⬆️
...at Items/PhotoMessages/Views/PhotoBubbleView.swift 74.6% <100%> (+0.2%) ⬆️
...ns/Source/Input/Photos/Camera/LiveCameraCell.swift 86.44% <100%> (+0.23%) ⬆️
...Messages/Views/TextMessageCollectionViewCell.swift 90.9% <100%> (+0.43%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e29fb1...cd7374b. Read the comment docs.

@AntonPalich AntonPalich merged commit aa67bac into badoo:master Sep 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants