Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed crash that happens only on Swift 3.2 projects that uses Chatto in release configuration #414

Merged
merged 1 commit into from
Dec 7, 2017

Conversation

AntonPalich
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Dec 5, 2017

Codecov Report

Merging #414 into master will increase coverage by 0.11%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #414      +/-   ##
==========================================
+ Coverage   64.74%   64.85%   +0.11%     
==========================================
  Files          70       70              
  Lines        4575     4578       +3     
  Branches      234      235       +1     
==========================================
+ Hits         2962     2969       +7     
+ Misses       1595     1591       -4     
  Partials       18       18
Impacted Files Coverage Δ
...ws/BaseMessageCollectionViewCellDefaultStyle.swift 87.85% <75%> (+0.35%) ⬆️
...Chat Items/TextMessages/Views/TextBubbleView.swift 74.65% <0%> (+1.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d3b591...724fb1c. Read the comment docs.

@AntonPalich AntonPalich merged commit 6d1973f into master Dec 7, 2017
@AntonPalich AntonPalich deleted the swift3.2_runtime_crash_in_release branch December 7, 2017 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants