Messages selection #411
Merged
Messages selection #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
November 28, 2017 14:23
…attoAdditions" This reverts commit 9c48f3b.
Codecov Report
@@ Coverage Diff @@
## master #411 +/- ##
=========================================
- Coverage 65.02% 64.83% -0.2%
=========================================
Files 70 70
Lines 4500 4575 +75
Branches 232 235 +3
=========================================
+ Hits 2926 2966 +40
- Misses 1557 1591 +34
- Partials 17 18 +1
Continue to review full report at Codecov.
|
geegaset
reviewed
Nov 30, 2017
| @@ -101,6 +103,8 @@ open class BaseMessagePresenter<BubbleViewT, ViewModelBuilderT, InteractionHandl | |||
| cell.performBatchUpdates({ () -> Void in | |||
| self.messageViewModel.showsTail = decorationAttributes.canShowTail | |||
| self.messageViewModel.showsAvatar = decorationAttributes.canShowAvatar | |||
| self.messageViewModel.isShowingSelectionIndicator = decorationAttributes.isShowingSelectionIndicator | |||
There was a problem hiding this comment.
the way how you copy all the attributes from one entity to another looks a little bit suspicious. why don't you have the dedicated entity which represents the whole set of properties? in this way copying would look like: self.mesageViewModel.attributes = decorationAttributes.attributes
| self.selectionIndicator.image = style.selectionIndicatorIcon(for: self.messageViewModel) | ||
| } | ||
|
|
||
| private lazy var selectionTapGestureRecognizer: UITapGestureRecognizer = { |
There was a problem hiding this comment.
does it really need to be lazy? it looks like it's used in init.
| self.bubbleViewFrame = bubbleSize.bma_rect(inContainer: containerRect, xAlignament: .center, yAlignment: .center) | ||
| self.failedButtonFrame = failedButtonSize.bma_rect(inContainer: containerRect, xAlignament: .center, yAlignment: .center) | ||
| self.avatarViewFrame = avatarSize.bma_rect(inContainer: containerRect, xAlignament: .center, yAlignment: parameters.avatarVerticalAlignment) | ||
| self.bubbleViewFrame = bubbleSize.bma_rect( |
There was a problem hiding this comment.
is this correct to use bma_ prefixes in Chatto code?
added 2 commits
December 1, 2017 10:27
…eMessageCollectionViewCell into a BaseMessageDecorationAttributes
geegaset
approved these changes
Dec 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BaseMessagesCollectionViewCellBaseMessagesCollectionViewCellto select/deselect messages in the chat