Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Xcode 9 warnings Swiftlint 0.23 #371

Merged
merged 2 commits into from
Oct 5, 2017
Merged

Fixed Xcode 9 warnings Swiftlint 0.23 #371

merged 2 commits into from
Oct 5, 2017

Conversation

AntonPalich
Copy link
Contributor

@AntonPalich AntonPalich commented Oct 5, 2017

Fixes #368

@AntonPalich AntonPalich merged commit 9945b5c into master Oct 5, 2017
@AntonPalich AntonPalich deleted the swiftlint_0.23 branch October 5, 2017 13:57
@codecov-io
Copy link

codecov-io commented Oct 5, 2017

Codecov Report

Merging #371 into master will increase coverage by 0.17%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #371      +/-   ##
==========================================
+ Coverage    63.9%   64.07%   +0.17%     
==========================================
  Files          63       63              
  Lines        3574     3577       +3     
==========================================
+ Hits         2284     2292       +8     
+ Misses       1290     1285       -5
Impacted Files Coverage Δ
.../Chat Items/BaseMessage/BaseMessagePresenter.swift 60.91% <ø> (ø) ⬆️
...dditions/Source/Input/Text/TextChatInputItem.swift 100% <ø> (ø) ⬆️
...ws/BaseMessageCollectionViewCellDefaultStyle.swift 86.15% <ø> (ø) ⬆️
...eMessage/Views/BaseMessageCollectionViewCell.swift 52.07% <ø> (ø) ⬆️
.../Source/Input/Photos/PhotosInputCameraPicker.swift 0% <0%> (ø) ⬆️
ChattoAdditions/Source/Input/ReusableXibView.swift 12.5% <0%> (ø) ⬆️
...ChatController/Collaborators/KeyboardTracker.swift 57.65% <0%> (ø) ⬆️
.../Source/Input/Photos/PhotosInputCellProvider.swift 0% <0%> (ø) ⬆️
...Additions/Source/Input/ChatInputBarPresenter.swift 66.66% <100%> (-0.43%) ⬇️
...hatController/BaseChatViewController+Changes.swift 88.75% <100%> (+0.88%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad48c00...f4ab73e. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants