Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new decoration property to enable/disable failed icon for a messa… #359

Merged
merged 2 commits into from
Sep 7, 2017
Merged

Conversation

turbulem
Copy link
Contributor

@turbulem turbulem commented Sep 6, 2017

Add new decoration property to enable/disable failed icon for a message. Change names for the ChatItemDecorationAttributes properties according to the single name convention. Add tests to cover new functionality.

Changes breaks existing interfaces for ChatItemDecorationAttributes and amend MessageViewModelProtocol with new writable property.

Serhii Zabrodko added 2 commits September 6, 2017 10:49
…ge. Change names for the ChatItemDecorationAttributes properties according to the single name convention. Add tests for new functionality.
@codecov-io
Copy link

codecov-io commented Sep 6, 2017

Codecov Report

Merging #359 into master will increase coverage by 0.02%.
The diff coverage is 93.33%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #359      +/-   ##
=========================================
+ Coverage   63.87%   63.9%   +0.02%     
=========================================
  Files          63      63              
  Lines        3563    3571       +8     
=========================================
+ Hits         2276    2282       +6     
- Misses       1287    1289       +2
Impacted Files Coverage Δ
.../Chat Items/BaseMessage/BaseMessagePresenter.swift 60.91% <100%> (+0.45%) ⬆️
.../Chat Items/BaseMessage/BaseMessageViewModel.swift 86.2% <100%> (+1.02%) ⬆️
...urce/Chat Items/ChatItemDecorationAttributes.swift 100% <100%> (ø) ⬆️
...eMessage/Views/BaseMessageCollectionViewCell.swift 52.07% <75%> (+0.44%) ⬆️
...Chat Items/TextMessages/Views/TextBubbleView.swift 68.75% <0%> (-1.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a67891...967aeeb. Read the comment docs.

@AntonPalich AntonPalich merged commit 16ad3bc into badoo:master Sep 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants