Fix inputContainer position when presenting BaseChatViewController as child #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… childViewController
AntonPalich
reviewed
Jul 24, 2017
| @@ -186,7 +186,15 @@ open class BaseChatViewController: UIViewController, UICollectionViewDataSource, | |||
| // If we have been pushed on nav controller and hidesBottomBarWhenPushed = true, then ignore bottomLayoutMargin | |||
| // because it has incorrect value when we actually have a bottom bar (tabbar) | |||
|
|
|||
| if self.hidesBottomBarWhenPushed && (navigationController?.viewControllers.count ?? 0) > 1 && navigationController?.viewControllers.last == self { | |||
| // Also if instance of BaseChatViewController is added as childViewController to another view controller, we had to check all this stuf on parent instance instead of self | |||
There was a problem hiding this comment.
@KaterinaPetrova Thank you for your changes!
May I ask you to move this code to a separate function setupInputContainerBottomConstraint? This method becomes too big now
Also, can you replace Ctrl with Controller. We are trying to avoid shorthand writing in this repo
There was a problem hiding this comment.
Yes, of coarse, thanks for review. I've put this function near inputContainerBottomConstraint variable declaration, is it okay?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we use BaseChatViewController as childViewController (for example, i need this, as i display chat only on half of the screen, or use it in pager container) check hidesBottomBarWhenPushed == true and navigationController?.viewControllers.last is not working (because last view controller is actually parentVC).
So we need to made this check on controller, which is really in navigation stack.