Allowing storyboard layout & custom main view class for BaseChatViewController #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ChatViewControllerView. Allows using storyboards and customize view class.
…iew in BaseChatViewController subclass.
Codecov Report
@@ Coverage Diff @@
## master #323 +/- ##
=========================================
Coverage ? 63.46%
=========================================
Files ? 63
Lines ? 3525
Branches ? 0
=========================================
Hits ? 2237
Misses ? 1288
Partials ? 0
Continue to review full report at Codecov.
|
AntonPalich
suggested changes
Jun 13, 2017
| @@ -167,7 +176,13 @@ open class BaseChatViewController: UIViewController, UICollectionViewDataSource, | |||
| sSelf.isAdjustingInputContainer = false | |||
| } | |||
| self.keyboardTracker = KeyboardTracker(viewController: self, inputContainer: self.inputContainer, layoutBlock: layoutBlock, notificationCenter: self.notificationCenter) | |||
| (self.view as? BaseChatViewControllerView)?.bmaInputAccessoryView = self.keyboardTracker?.trackingView | |||
|
|
|||
| // Compiler can't understand this cast inline. | |||
There was a problem hiding this comment.
This is because protocol is not restricted for classes only. Value types can implement it as well. Compiler doesn't allow to modify value type declared with let keyword. Can you fix it?
There was a problem hiding this comment.
Thanks for the tip. Fixed.
| // Compiler can't understand this cast inline. | ||
| // Although we are only setting a property on a constant, it believes that we change reference to it. | ||
| // We do not. | ||
| if var customView = (self.view as? BaseChatViewControllerViewProtocol) { |
There was a problem hiding this comment.
Please, remove parentheses
…ned up setting bmaAccessoryInputView
AntonPalich
approved these changes
Jul 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've faced a problem trying to subclass an already existing VC from BaseChatViewController.
It had some storyboard layout, and its view was of a custom class with some presentation logic.
However loadView() in BaseChatViewController replaced VC's main view with BaseChatViewControllerView & setupKeyboardTracker() didn't set bmaInputAccessoryView unless it stayed that way.
Now we can work with custom view taken from storyboard:
_
var bmaInputAccessoryView: UIView?
override var inputAccessoryView: UIView? {
return self.bmaInputAccessoryView
}
_