Add [StackExchange] monthly questions badge service (#2378) #2432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Badge shows number of questions for a given library for the previous month (not current month because its in progress) - Service works for not just the StackOverflow site but for other StackExchange sites also If merged, closes issue badges#2378
paulmelnikow
reviewed
Dec 3, 2018
services/stackexchange/stackexchange-monthlyquestions.service.js
Outdated
Show resolved
Hide resolved
services/stackexchange/stackexchange-monthlyquestions.tester.js
Outdated
Show resolved
Hide resolved
services/stackexchange/stackexchange-monthlyquestions.tester.js
Outdated
Show resolved
Hide resolved
services/stackexchange/stackexchange-monthlyquestions.service.js
Outdated
Show resolved
Hide resolved
1. Refactor render function to be common helper 2. Change url pattern 3. Slight changes to tests due to 2
paulmelnikow
approved these changes
Dec 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(not current month because its in progress)
Example:
If merged, closes issue #2378