Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix URL pattern for [StackExchange] Questions and Reputation per PR #2418 #2430

Merged
merged 3 commits into from
Nov 30, 2018
Merged

Fix URL pattern for [StackExchange] Questions and Reputation per PR #2418 #2430

merged 3 commits into from
Nov 30, 2018

Conversation

bui1
Copy link
Contributor

@bui1 bui1 commented Nov 29, 2018

  • Url patterns have been changed back to their older legacy format.
  • Tests now run properly with this URL in addition to the examples showing up on local.

@paulmelnikow Apologies for the previous PR that may have broken stuff. I hope this one will do much better

@bui1
Fix URL pattern for StackExchange Questions and Reputation per badges…
6de40d9 
…#2418

Url patterns have been changed back to their older legacy format.
Tests now run properly with this URL in addition to the examples
showing up on local.
@bui1 bui1 changed the title Fix URL pattern for [StackExchange] Questions and Reputation per #2418 Fix URL pattern for [StackExchange] Questions and Reputation per PR #2418 Nov 29, 2018
@shields-ci
Copy link

Messages
📖 ✨ Thanks for your contribution to Shields, @bui1!

Generated by 🚫 dangerJS

paulmelnikow
paulmelnikow reviewed Nov 29, 2018
View reviewed changes
Copy link
Member

@paulmelnikow paulmelnikow left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for picking this up!

I do like the new pattern better, and wouldn't mind deprecating the old one and redirecting users to the new one. Though let's get this merged first.

services/stackexchange/stackexchange-reputation.service.js Outdated Show resolved Hide resolved
@paulmelnikow paulmelnikow added service-badge New or updated service badge blocker PRs and epics which block other work labels Nov 29, 2018
@paulmelnikow
Copy link
Member

Thanks!

@paulmelnikow paulmelnikow merged commit 3b3dd9f into badges:master Nov 30, 2018
@shields-deployment
Copy link

This pull request was merged to master branch. This change is now waiting for deployment, which will usually happen within a few days. Stay tuned by joining our #ops channel on Discord!

After deployment, changes are copied to gh-pages branch:

@paulmelnikow
Copy link
Member

Nice! This is live on s0 and I'm seeing the same text (though different color, as expected):

https://s0.shields-server.com/stackexchange/stackoverflow/r/893113.svg

https://s1.shields-server.com/stackexchange/stackoverflow/r/893113.svg

@paulmelnikow
Copy link
Member

And… live everywhere! Congrats 😄

@bui1
Copy link
Contributor Author

bui1 commented Nov 30, 2018

Super sick to see my work live it's pretty awesome 😃 Thanks for all your help @paulmelnikow!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulmelnikow paulmelnikow paulmelnikow approved these changes

Assignees
No one assigned
Labels
blocker PRs and epics which block other work service-badge New or updated service badge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bui1 @shields-ci @paulmelnikow