-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The @types/styled-components mess #5294
Labels
dependencies
Related to dependency updates
Comments
This was referenced Jul 19, 2020
I'm using the hacky workaround in another project. It seems to be working fine and means we can use the up-to-date type defs and latest TypeScript. If no one objects I'll open a PR to do that here. |
paulmelnikow
added a commit
that referenced
this issue
Sep 21, 2020
@types/styled-components causes a conflict with @types/react-native. See DefinitelyTyped/DefinitelyTyped#33311. Close #5294
No objections whatsoever! |
repo-ranger bot
added a commit
that referenced
this issue
Sep 22, 2020
@types/styled-components causes a conflict with @types/react-native. See DefinitelyTyped/DefinitelyTyped#33311. Close #5294 Co-authored-by: repo-ranger[bot] <39074581+repo-ranger[bot]@users.noreply.github.com>
DefinitelyTyped/DefinitelyTyped#49914 Hallelujah! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Wanted to surface this here rather than burying it in a dependabot PR…
As @calebcartwright observed at #5277 (comment) the version of
@types/styled-components
that we've pinned as a result of DefinitelyTyped/DefinitelyTyped#33311 is now blocking us from updating TypeScript.This is untenable.
Part of me wants to try to dive into the DefTyped repo and fix this though I just don't have a ton of bandwidth.
Increasingly the hacky workaround of deleting
node_modules/@types/react-native
, a package which of course should not be installed into Shields, is feeling like a reasonable way to handle this.The text was updated successfully, but these errors were encountered: