Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(step_definition): Add option to define path for the common folder #138

Merged
merged 2 commits into from
Feb 7, 2019

Conversation

EmmanuelDemey
Copy link
Contributor

@EmmanuelDemey EmmanuelDemey commented Jan 28, 2019

@lgandecki
Copy link
Collaborator

Cool. I like your approach, with tests and all. Looks like we need to fill the missing parts of the documentation still before we can merge it, so we don't release with a confusing doc.
Do you want to take a stab at filling it in? Don't stress it too much - we will merge it with whatever you propose (as long as it's not technically incorrect ;-) ), and we will tweak it later if needed be.

@EmmanuelDemey
Copy link
Contributor Author

Let me do it this afternoon

@lgandecki
Copy link
Collaborator

cool, thank you so much!

@EmmanuelDemey
Copy link
Contributor Author

EmmanuelDemey commented Jan 28, 2019

I have some difficulty to define the goal of the nonGlobalStepDefinitions option. Do you have an idea ?

@lgandecki
Copy link
Collaborator

It's the difference between using the Cypress Cucumber Preprocessor Style pattern for placing step definitions files, and the "oldschool" (everything is global) Cucumber style

@EmmanuelDemey
Copy link
Contributor Author

updated

@lgandecki lgandecki merged commit a8d3df6 into badeball:master Feb 7, 2019
@lgandecki
Copy link
Collaborator

🎉 This PR is included in version 1.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@EmmanuelDemey EmmanuelDemey deleted the common-path branch February 19, 2019 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants