Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix methods which read wchart data #98

Merged
merged 2 commits into from
Jun 17, 2024
Merged

Conversation

badcel
Copy link
Owner

@badcel badcel commented Jun 12, 2024

Fixes: #97

HIDAPI expects the buffer size to be in multiples of sizeof(wchar_t) and not byte.
@badcel badcel force-pushed the fix-methods-which-read-wchart-data branch 3 times, most recently from 70efabc to 703e246 Compare June 16, 2024 20:25
As the wchar_t buffer is filled with a null terminated string all the obsolete characters can be removed.
@badcel badcel force-pushed the fix-methods-which-read-wchart-data branch from 703e246 to 1ec5f27 Compare June 16, 2024 20:39
@badcel badcel merged commit bee6fb6 into main Jun 17, 2024
3 checks passed
@badcel badcel deleted the fix-methods-which-read-wchart-data branch June 17, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Read serial number (and other strings) may cause memory corruption
1 participant