Add Read overloads for passing in buffer #102
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #101
Warning: I did tested this only briefly (with a short bit of temporary code in
HidApi.Tester
). Can you recommend a good way to test it beyond that?The method signatures had to slightly change compared to what we last discussed in the issue:
As the
Read
might not fill the whole buffer, the new overloads have to return the read length. I believe this is another good reason to leave the previous signatures intact, as they prevent this mistake.