Merge pull request #62 from tmittet/Address_CA2201_Do_not_raise_reser…

…ved_exception_types
badcel · Nov 18, 2023 · 37e9b42 · 37e9b42
2 parents 1c687e1 + 0fa887d
commit 37e9b42
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/src/HidApi.Net/Internal/NativeHidApiLibrary.cs b/src/HidApi.Net/Internal/NativeHidApiLibrary.cs
@@ -15,7 +15,7 @@ public static IEnumerable<string> GetNames()
         if (RuntimeInformation.IsOSPlatform(OSPlatform.OSX))
             return GetOsxNames();
 
-        throw new Exception("Unsupported platform to get hidapi library name");
+        throw new NotSupportedException("Unsupported platform to get hidapi library name");
     }
 
     private static IEnumerable<string> GetLinuxNames()

diff --git a/src/HidApi.Net/Internal/NativeMethods.cs b/src/HidApi.Net/Internal/NativeMethods.cs
@@ -25,7 +25,7 @@ private static IntPtr Resolve(string libraryName, Assembly assembly, DllImportSe
             if (NativeLibrary.TryLoad(library, assembly, searchPath, out libraryHandle))
                 return libraryHandle;
 
-        throw new Exception($"Could not find hidapi library tried: {string.Join(", ", NativeHidApiLibrary.GetNames())}");
+        throw new DllNotFoundException($"Could not find hidapi library tried: {string.Join(", ", NativeHidApiLibrary.GetNames())}");
     }
 
     public static DeviceSafeHandle Open(ushort vendorId, ushort productId, NullTerminatedString serialNumber)

diff --git a/src/HidApi.Net/Internal/WCharT.cs b/src/HidApi.Net/Internal/WCharT.cs
@@ -16,7 +16,7 @@ public static string GetString(ReadOnlySpan<byte> buffer)
         if (RuntimeInformation.IsOSPlatform(OSPlatform.OSX))
             return Encoding.UTF32.GetString(buffer);
 
-        throw new Exception("Unsupported platform to read from buffer");
+        throw new NotSupportedException("Unsupported platform to read from buffer");
     }
 
     public static unsafe string GetString(byte* ptr)
@@ -30,7 +30,7 @@ public static unsafe string GetString(byte* ptr)
         if (RuntimeInformation.IsOSPlatform(OSPlatform.OSX))
             return Utf32.Read(ptr);
 
-        throw new Exception("Unsupported platform to read from pointer");
+        throw new NotSupportedException("Unsupported platform to read from pointer");
     }
 
     public static ReadOnlySpan<byte> CreateBuffer(int size)
@@ -44,7 +44,7 @@ public static ReadOnlySpan<byte> CreateBuffer(int size)
         if (RuntimeInformation.IsOSPlatform(OSPlatform.OSX))
             return Utf32.CreateBuffer(size);
 
-        throw new Exception("Unsupported platform to create a buffer");
+        throw new NotSupportedException("Unsupported platform to create a buffer");
     }
 
     public static NullTerminatedString CreateNullTerminatedString(string str)
@@ -58,6 +58,6 @@ public static NullTerminatedString CreateNullTerminatedString(string str)
         if (RuntimeInformation.IsOSPlatform(OSPlatform.OSX))
             return Utf32.CreateNullTerminatedString(str);
 
-        throw new Exception("Unsupported platform to create a null terminated string");
+        throw new NotSupportedException("Unsupported platform to create a null terminated string");
     }
 }