Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dark theme support #59

Merged
merged 4 commits into from
Apr 5, 2024
Merged

Add dark theme support #59

merged 4 commits into from
Apr 5, 2024

Conversation

gsalinaslopez
Copy link
Contributor

Closes #6. The app will change its color scheme between light (original look) and dark theme based on the OS level settings (Android 10 and higher)

Changes

Screenshots

Main Screen Settings popup menu Client Settings About Page
Screenshot_20231004-142007 Screenshot_20231004-142106 Screenshot_20231004-142522 Screenshot_20231004-142302

Notes

The original app's color scheme remains unchanged, now becoming the default "Light Theme"

…theme definitions into their own xml resource file
…and dark themes. Moved default light background body color
…S rules to display the source image depending on the prefered-color-scheme tag
@gsalinaslopez
Copy link
Contributor Author

Hi @badaix

Have you had time to take a look at this PR? It should be pretty straightforward and it implements
#6

Thanks!

@badaix
Copy link
Owner

badaix commented Apr 3, 2024

Hi @gsalinaslopez sorry, I completely missed this PR. I will check ASAP, latest the upcoming weekend :)

@badaix badaix changed the base branch from master to v0.28.0 April 5, 2024 08:32
@badaix badaix merged commit b939109 into badaix:v0.28.0 Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FR: Dark theme for Android
2 participants