Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak Airplay #1102

Merged
merged 2 commits into from
Jul 14, 2023
Merged

Tweak Airplay #1102

merged 2 commits into from
Jul 14, 2023

Conversation

yubiuser
Copy link
Contributor

This PR improves the Airplay handling with the shairport-sync backend. It addresses 3 issues.

  1. If compiled without HAS_EXPAT=1, a warning will be thrown and the metadata handling probably won't work.
    #ifdef HAS_EXPAT
    createParser();
    metadata_dirty_ = false;
    #else
    LOG(INFO, LOG_TAG) << "Metadata support not enabled (HAS_EXPAT not defined)"
    << "\n";
    #endif

    There was no documentation of this flag so far, it was only listed in the commit message of fdcdf8e. This PR adds some documentation
  2. shairport-sync supports Airplay 2 now. It uses port 7000. https://github.com/mikebrady/shairport-sync/blob/6240fd83707b77fe2fb2250f8136e530e36010d2/man/shairport-sync.html#L313-L314. This PR adds documentation.
  3. Airplay backend sets --use-stderr. This option is deprecated. https://github.com/mikebrady/shairport-sync/blob/6240fd83707b77fe2fb2250f8136e530e36010d2/shairport.c#L327

@badaix
Copy link
Owner

badaix commented Jul 14, 2023

Thanks, I removed the HAS_EXPAT section, because plain make support has been dropped and CMake will use Expat, except you switch it explicitly off.

@badaix badaix merged commit abe6dea into badaix:develop Jul 14, 2023
@yubiuser yubiuser deleted the airplay branch July 14, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants