New setting "streaming_client.initial_volume" #1024
Conversation
| @@ -156,6 +156,11 @@ source = pipe:///tmp/snapfifo?name=default | |||
| # Send audio to muted clients | |||
| #send_to_muted = false | |||
| # | |||
|
|
|||
| # Volume assigned to new snapclients [percent] | |||
There was a problem hiding this comment.
Can you please create a new config section streaming_client?
Because this is not really related to a stream, but to a client, and there are two kinds of clients: streaming and control.
Maybe this section will be extended later with e.g. black lists, white lists of client IPs or certificates and what not.
Also please rename the setting to initial_volume and keep the comment that the unit is percent, like this:
# streaming client options ####################################################
#
[streaming_client]
# Volume assigned to new snapclients [percent]
# Defaults to 100 if unset
#initial_volume = 100
#
###############################################################################
doc/configuration.md
Outdated
| @@ -27,6 +27,7 @@ Within the `[stream]` section there are some global parameters valid for all `so | |||
| - `chunk_ms`: Default source stream read chunk size [ms]. The server will continously read this number of milliseconds from the source into a buffer, before this buffer is passed to the encoder (the `codec` above) | |||
| - `buffer`: Buffer [ms]. The end-to-end latency, from capturing a sample on the server until the sample is played-out on the client | |||
| - `send_to_muted`: `true` or `false`: Send audio to clients that are muted | |||
| - `initial_client_percent`: 0-100 [percent]: The volume an audio client gets assigned on very first connect (i.e. client not known to snapserver yet). Defaults to 100 if unset or invalid (e.g. out of bounds). | |||
There was a problem hiding this comment.
Please change according to the requested changes for server/etc/snapserver.conf (below).
server/server_settings.hpp
Outdated
| @@ -63,6 +63,7 @@ struct ServerSettings | |||
| size_t streamChunkMs{20}; | |||
| bool sendAudioToMutedClients{false}; | |||
| std::vector<std::string> bind_to_address{{"0.0.0.0"}}; | |||
| uint16_t initialClientPercent{100}; | |||
There was a problem hiding this comment.
Please add a new struct StreamingClient with uint16_t initialVolume
|
Thanks a lot for your feedback and especially for the architecture clarification. Please have another look 😄 |
nis65
changed the title
|
Tack så mycket! 👍 |
This resolves #910.
Testcases executed manually:
/etc/snapserver.conf(identical to behaviour without this change). Volume is set to configured value when set. When configuration value is invalid, initial value is set to 100 too./var/lib/snapserver/server.json): Previous volume is unchanged.Tested successfully both on current
masterand currentdevelop.