Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add delete function and more tests #27

Merged
merged 15 commits into from
Oct 3, 2024
Merged

Add delete function and more tests #27

merged 15 commits into from
Oct 3, 2024

Conversation

johannahelene
Copy link
Collaborator

  • add codecov
  • add status badges
  • add delete function
  • tests for distances.rs

Copy link

codecov bot commented Sep 16, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

src/cli.rs Outdated Show resolved Hide resolved
src/cli.rs Outdated Show resolved Hide resolved
src/lib.rs Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/multisketch.rs Outdated Show resolved Hide resolved
tests/delete.rs Show resolved Hide resolved
tests/distance.rs Outdated Show resolved Hide resolved
tests/distance.rs Outdated Show resolved Hide resolved
tests/distance.rs Outdated Show resolved Hide resolved
tests/test_files_in/distances.rs Outdated Show resolved Hide resolved
@johnlees johnlees changed the title Johanna dev Add delete function and more tests Sep 16, 2024
@johnlees
Copy link
Member

Good to give the PR a specific title – it's useful when you want to look it up in future

@johannahelene johannahelene requested a review from johnlees October 2, 2024 16:26
Copy link
Member

@johnlees johnlees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few very minor final changes

src/lib.rs Outdated Show resolved Hide resolved
src/multisketch.rs Outdated Show resolved Hide resolved
src/sketch.rs Show resolved Hide resolved
tests/delete.rs Outdated Show resolved Hide resolved
tests/distance.rs Outdated Show resolved Hide resolved
@johannahelene johannahelene requested a review from johnlees October 3, 2024 15:15
@johnlees johnlees merged commit 38a2a28 into main Oct 3, 2024
9 checks passed
@johnlees johnlees deleted the johanna_dev branch October 3, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants