current state #22
johannaheleneAnnotations
1 error and 14 warnings
|
build
Process completed with exit code 101.
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/lib.rs#L482
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/lib.rs:482:80
|
482 | let sketch_vec = MultiSketch::new(&mut mini_sketches, sketch_size, &kmers, seq_type, true);
| ^^^^^^ help: change this to: `kmers`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/lib.rs#L458
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/lib.rs:458:17
|
458 | &kmers,
| ^^^^^^ help: change this to: `kmers`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
|
the following explicit lifetimes could be elided: 'a:
src/distances.rs#L269
warning: the following explicit lifetimes could be elided: 'a
--> src/distances.rs:269:6
|
269 | impl<'a> fmt::Display for SparseDistanceMatrix<'a> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
269 - impl<'a> fmt::Display for SparseDistanceMatrix<'a> {
269 + impl fmt::Display for SparseDistanceMatrix<'_> {
|
|
|
non-canonical implementation of `partial_cmp` on an `Ord` type:
src/distances.rs#L214
warning: non-canonical implementation of `partial_cmp` on an `Ord` type
--> src/distances.rs:214:1
|
214 | / impl PartialOrd for SparseCoreAcc {
215 | | fn partial_cmp(&self, other: &Self) -> Option<Ordering> {
| | _____________________________________________________________-
216 | || self.1.partial_cmp(&other.1)
217 | || }
| ||_____- help: change this to: `{ Some(self.cmp(other)) }`
218 | | }
| |__^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl
|
|
non-canonical implementation of `partial_cmp` on an `Ord` type:
src/distances.rs#L188
warning: non-canonical implementation of `partial_cmp` on an `Ord` type
--> src/distances.rs:188:1
|
188 | / impl PartialOrd for SparseJaccard {
189 | | fn partial_cmp(&self, other: &Self) -> Option<Ordering> {
| | _____________________________________________________________-
190 | || other.1.partial_cmp(&self.1) // NB: backwards
191 | || }
| ||_____- help: change this to: `{ Some(self.cmp(other)) }`
192 | | }
| |__^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl
= note: `#[warn(clippy::non_canonical_partial_ord_impl)]` on by default
|
|
the following explicit lifetimes could be elided: 'a:
src/distances.rs#L139
warning: the following explicit lifetimes could be elided: 'a
--> src/distances.rs:139:6
|
139 | impl<'a> fmt::Display for DistanceMatrix<'a> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
|
139 - impl<'a> fmt::Display for DistanceMatrix<'a> {
139 + impl fmt::Display for DistanceMatrix<'_> {
|
|
|
this function has too many arguments (10/7):
src/sketch.rs#L222
warning: this function has too many arguments (10/7)
--> src/sketch.rs:222:1
|
222 | / pub fn sketch_files(
223 | | output_prefix: &str,
224 | | input_files: &[InputFastx],
225 | | concat_fasta: bool,
... |
232 | | inverted: bool,
233 | | ) -> Vec<Sketch> {
| |________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
= note: `#[warn(clippy::too_many_arguments)]` on by default
|
|
fields `bin_stride`, `kmer_stride`, and `sample_stride` are never read:
src/sketch_datafile.rs#L11
warning: fields `bin_stride`, `kmer_stride`, and `sample_stride` are never read
--> src/sketch_datafile.rs:11:5
|
10 | pub struct SketchArrayFile {
| --------------- fields in this struct
11 | bin_stride: usize,
| ^^^^^^^^^^
12 | kmer_stride: usize,
| ^^^^^^^^^^^
13 | sample_stride: usize,
| ^^^^^^^^^^^^^
|
= note: `SketchArrayFile` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
= note: `#[warn(dead_code)]` on by default
|
|
unused variable: `inverted`:
src/multisketch.rs#L48
warning: unused variable: `inverted`
--> src/multisketch.rs:48:9
|
48 | inverted: bool,
| ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_inverted`
|
= note: `#[warn(unused_variables)]` on by default
|
|
build
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
build
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
build
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
build
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
build
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|