warning: use of `expect` followed by a function call --> src/lib.rs:483:18 | 483 | .expect(&format!("Could not save metadata to {}", output)); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("Could not save metadata to {}", output))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call

warning: use of `expect` followed by a function call --> src/lib.rs:422:18 | 422 | .expect(&format!("Could not read sketch metadata from .skm: {}", db)); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("Could not read sketch metadata from .skm: {}", db))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call = note: `#[warn(clippy::expect_fun_call)]` on by default

warning: non-canonical implementation of `partial_cmp` on an `Ord` type --> src/distances.rs:214:1 | 214 | / impl PartialOrd for SparseCoreAcc { 215 | | fn partial_cmp(&self, other: &Self) -> Option<Ordering> { | | _____________________________________________________________- 216 | || self.1.partial_cmp(&other.1) 217 | || } | ||_____- help: change this to: `{ Some(self.cmp(other)) }` 218 | | } | |__^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl

warning: non-canonical implementation of `partial_cmp` on an `Ord` type --> src/distances.rs:188:1 | 188 | / impl PartialOrd for SparseJaccard { 189 | | fn partial_cmp(&self, other: &Self) -> Option<Ordering> { | | _____________________________________________________________- 190 | || other.1.partial_cmp(&self.1) // NB: backwards 191 | || } | ||_____- help: change this to: `{ Some(self.cmp(other)) }` 192 | | } | |__^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl = note: `#[warn(clippy::non_canonical_partial_ord_impl)]` on by default

warning: this function has too many arguments (9/7) --> src/sketch.rs:205:1 | 205 | / pub fn sketch_files( 206 | | output_prefix: &str, 207 | | input_files: &[InputFastx], 208 | | concat_fasta: bool, ... | 214 | | min_qual: u8, 215 | | ) -> Vec<Sketch> { | |________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments = note: `#[warn(clippy::too_many_arguments)]` on by default

warning: fields `bin_stride`, `kmer_stride`, and `sample_stride` are never read --> src/sketch_datafile.rs:11:5 | 10 | pub struct SketchArrayFile { | --------------- fields in this struct 11 | bin_stride: usize, | ^^^^^^^^^^ 12 | kmer_stride: usize, | ^^^^^^^^^^^ 13 | sample_stride: usize, | ^^^^^^^^^^^^^ | = note: `SketchArrayFile` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis = note: `#[warn(dead_code)]` on by default

warning: unused variable: `ids` --> src/multisketch.rs:150:35 | 150 | pub fn remove_sketches(&self, ids: &[String]) { | ^^^ help: if this is intentional, prefix it with an underscore: `_ids` | = note: `#[warn(unused_variables)]` on by default

The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/