Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for using visualise with indiv refine ref-db #261

Merged
merged 2 commits into from
Apr 19, 2023
Merged

Conversation

johnlees
Copy link
Member

Bit of an edge case I suppose, but currently crashes because the query DB only contains one of the expected columns. Now just take the intersection to use the model used during querying

@johnlees johnlees requested a review from nickjcroucher April 13, 2023 15:37
@nickjcroucher nickjcroucher self-assigned this Apr 13, 2023
Copy link
Collaborator

@nickjcroucher nickjcroucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find, just a suggestion on making the old printed statement more specific given the extra info you've added

PopPUNK/utils.py Outdated Show resolved Hide resolved
Co-authored-by: nickjcroucher <[email protected]>
@johnlees johnlees merged commit 7cb20a0 into master Apr 19, 2023
@johnlees johnlees deleted the indiv-viz branch April 19, 2023 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants