Move the extend algorithm into the C++ extension #178
Conversation
|
Timing of extend on 10k ref vs 10k query: |
| bool self = true, const int int_offset = 0) { | ||
| edge_tuple edges = | ||
| generate_all_tuples(num_ref, num_queries, self, int_offset); | ||
| return (edges); | ||
| } |
There was a problem hiding this comment.
You just hate whitespace, don't you?
There was a problem hiding this comment.
You need to install the best vs code extension around: https://marketplace.visualstudio.com/items?itemName=shardulm94.trailing-spaces
There was a problem hiding this comment.
And then once you've accepted that into your life, you can get really pedantic: https://marketplace.visualstudio.com/items?itemName=oderwat.indent-rainbow
There was a problem hiding this comment.
Although actually this particular change was courtesy of: https://marketplace.visualstudio.com/items?itemName=xaver.clang-format
There was a problem hiding this comment.
(I have a lot of extensions)
There was a problem hiding this comment.
I would inevitably manage to install two extensions with conflicting preferences that would infinite loop as soon as I indented a line
This is a good point, and though it works correctly, I've already confused myself once because the name suggests the opposite meaning to what it should be |
This moves LineageFit.extend to the poppunk_refine extension. The algorithm is similar to that used in sparsifyDists in pp_sketchlib, but works specifically with a combination of sparse and dense matrices. The highest rank is computed, and then lowered to get smaller ranks. Parallelisation supported.