-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to MST #148
Updates to MST #148
Conversation
(I don't know why |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for these fixes/improvements. A couple of suggestions on the code.
Also:
- The tests appear to be failing
- The distances in sparse_mst just load the sample names from the
.pkl
file and not the dense matrix. But really these should be optional, and only required if the clusters are provided (as it is valid to not colour the nodes by strain). Maybe you could make that change? Or alternatively, can we expect the sample names to be stored as a vertex property?
Can we also pin the version of graph-tool, had a few reports of that going wrong.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these are already incorporated, but approving again just in case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also add to the environment.yml cugraph and cudf (I think you would also need to add nvidia to the channel list at the top of the file)
Co-authored-by: John Lees <[email protected]>
Co-authored-by: John Lees <[email protected]>
Co-authored-by: John Lees <[email protected]>
Added cugraph and cudf to environment.yml in 3e5160e. |
Minor updates:
--previous-clustering
now requires a specific file in both visualise and plot_mst modesNot sure about:
sparse_mst.py
still requires--distances
, do we still require calculation of all-v-all, or are we just using the "metadata" without calculating the values?