Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alternative network scores #146

Merged
merged 34 commits into from
Jan 31, 2021
Merged

Add alternative network scores #146

merged 34 commits into from
Jan 31, 2021

Conversation

johnlees
Copy link
Member

Adds two new networks scores based on betweenness

Even if these turn out to be less useful than the original score, I think this code is useful as using them is optional, and there is some other tidying included here

Closes #126

@johnlees
Copy link
Member Author

If bacpop/pp-sketchlib#46 is quick, this could also be added here

@johnlees
Copy link
Member Author

May be best to add #147 here

@johnlees
Copy link
Member Author

Check weighted betweenness is still working

Creates new extension poppunk_refine
@johnlees johnlees linked an issue Jan 26, 2021 that may be closed by this pull request
johnlees added a commit to bacpop/pp-sketchlib that referenced this pull request Jan 26, 2021
@johnlees johnlees marked this pull request as ready for review January 27, 2021 12:04
@johnlees
Copy link
Member Author

Check weighted betweenness is still working

Fixed in 89c1252

@johnlees johnlees merged commit a43a96c into master Jan 31, 2021
@johnlees johnlees deleted the network-score branch January 31, 2021 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move C++ network code from sketchlib into PopPUNK New network score
1 participant