-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add calculation of minimum spanning trees #141
Conversation
@nickjcroucher Could you merge the master branch in? |
Will do - just for inspiration, here is the MSTree code from Grapetree, which may be helpful: https://github.com/achtman-lab/GrapeTree/blob/master/module/MSTrees.py |
Also I'm not sure why the tests aren't running on this PR, I can try and sort that out too |
I've edited the config slightly on master, so hopefully merging master in should get the testing running on this branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall! Changes here are mostly minor formatting/style things.
Still needed before merge:
- Correct implementation of sparse matrix joining
- Pin the version of dendropy in
environment.yml
now the midpoint rooting is fixed (and double-check NJ trees are correct, if we haven't already) - Add a test which runs the MST
- Add an example to the visualisation docs
- Add cuGraph version (see also GPU accelerated graphs #87)
- Draw the MST as a network rather than tree (cytoscape or graphtool)
-
Alternative way of sparsifying graph (threshold/max memory approach)
I will raise a separate issue with ideas which might improve this, and we can decide whether to add this in this merge, or work on them more later
Co-authored-by: John Lees <[email protected]>
Co-authored-by: John Lees <[email protected]>
No longer exit on error
This is an inadequate implementation currrently. A design choice needs to be made about whether:
dendropy
seed_node)