-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch networkx for graph-tool #82
Comments
(Very limited) start here: 7260e50. Slightly fiddly import code in network.py. |
Working for main strain assigning functions in 5623a67. Networkx version run on SPARC: https://microreact.org/project/9KY6djAvD (easy run took 1m56.113s on 24 threads) Running detectably faster on only a few hundred genomes. Only remaining networkx dependence is in the lineage_assignment. |
Note that networks now store vertex labels as integers, not strings. Fiddly to remove and extend the network. Will need to check the behaviour with queries being added. |
Great! |
Yep, I think it is probably better, I just can't quite get my head around the way in which nodes are removed/added - e.g. after removal, the remaining are still consecutively labelled, so there needs to be some way of keeping track of what's what. It is possible to associate data with a vertex, but not sure how links are retained in e.g. shrinkage processes. Another nice feature is that networks can be masked, e.g. for the visualisation code, rather than copied and pruned. This version seems much faster with the refinement steps for large networks, I think it is definitely a worthwhile change. |
Lineage model fitting - sketchlib changes
See https://graph-tool.skewed.de/static/doc/index.html
The text was updated successfully, but these errors were encountered: