Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Where does pip install the scripts/ #56

Closed
tseemann opened this issue Oct 28, 2019 · 7 comments
Closed

Where does pip install the scripts/ #56

tseemann opened this issue Oct 28, 2019 · 7 comments
Assignees
Labels
package Packaging of code

Comments

@tseemann
Copy link

Looking for https://poppunk.readthedocs.io/en/latest/scripts.html

Does pip3 install poppunk install these somewhere?

@johnlees
Copy link
Member

johnlees commented Nov 4, 2019

Hi Torsten,

Sorry for the slow reply. No, I haven't set up either pip or conda to install the scripts as of the current version.
In the next release I'll update the installers to include them, but for now to get them you'll have to clone the repository.

Cheers,
John

@johnlees johnlees self-assigned this Nov 4, 2019
@johnlees johnlees added the package Packaging of code label Nov 4, 2019
@tseemann
Copy link
Author

tseemann commented Nov 5, 2019

Colleagues were doing the tutorial etc and came up against this roadblock.
Thanks for replying,.

johnlees added a commit that referenced this issue Nov 18, 2019
Closes #49

Also hoping this adds scripts to install through MANIFEST.in (#56), but will check when releasing
@johnlees
Copy link
Member

These have now been added (I hope) and documented on the scripts page: https://poppunk.readthedocs.io/en/latest/scripts.html

@tseemann
Copy link
Author

Any chance they will be added to the pip manifest so they end up in bin/ folder?
And maybe rename them to have prefix poppunk-_______ ?

@johnlees
Copy link
Member

I believe that's exactly what I did in 7677d72 and 83b1a62. If this isn't working correctly let me know, or feel free to make a PR to fix it

@tseemann
Copy link
Author

tseemann commented Nov 26, 2019

Ok - they are there now - thank you!

poppunk                            poppunk_extract_distances.py
poppunk_calculate_rand_indices.py  poppunk_prune
poppunk_calculate_silhouette.py    poppunk_references
poppunk_extract_components.py      poppunk_tsne

 $ poppunk --version
PopPUNK 1.2.2

@johnlees
Copy link
Member

Hoping that conda automatically picks these up with its version bump too!

ccoulombe pushed a commit to ccoulombe/PopPUNK that referenced this issue Oct 28, 2022
Update random object when not all references contained
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package Packaging of code
Projects
None yet
Development

No branches or pull requests

2 participants