Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename attributes and add them as default #127

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

konraddysput
Copy link
Collaborator

Why

This pull request always adds metrics that we thought are "metrics specific". We always want to include the session id, application version application build in the crash reports.

@konraddysput konraddysput added the enhancement New feature or request label Jun 24, 2024
@konraddysput konraddysput requested a review from melekr June 24, 2024 16:55
@konraddysput konraddysput self-assigned this Jun 24, 2024
Copy link
Collaborator

@melekr melekr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@melekr melekr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@konraddysput konraddysput merged commit 34a4b3c into master Jun 24, 2024
4 checks passed
@konraddysput konraddysput deleted the improvement/application-attribute-source branch June 24, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants