-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metrics performance improvements #157
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konraddysput
commented
Nov 5, 2024
backtrace-library/src/androidTest/java/backtraceio/library/BacktraceClientUniqueEventTest.java
Show resolved
Hide resolved
backtrace-library/src/main/java/backtraceio/library/common/ApplicationHelper.java
Outdated
Show resolved
Hide resolved
backtrace-library/src/main/java/backtraceio/library/common/ApplicationHelper.java
Outdated
Show resolved
Hide resolved
backtrace-library/src/main/java/backtraceio/library/common/ApplicationHelper.java
Outdated
Show resolved
Hide resolved
backtrace-library/src/main/java/backtraceio/library/common/DeviceAttributesHelper.java
Outdated
Show resolved
Hide resolved
backtrace-library/src/main/java/backtraceio/library/common/ApplicationHelper.java
Outdated
Show resolved
Hide resolved
backtrace-library/src/main/java/backtraceio/library/models/json/ReportDataBuilder.java
Outdated
Show resolved
Hide resolved
backtrace-library/src/main/java/backtraceio/library/models/json/ReportDataBuilder.java
Outdated
Show resolved
Hide resolved
backtrace-library/src/main/java/backtraceio/library/models/json/ReportDataBuilder.java
Outdated
Show resolved
Hide resolved
to be honest I really don't like introducing tuples because of
It's easier just to wrap two fields with small object and pass it together if they are logically combined, if not then maybe code is bad designed. |
melekr
approved these changes
Nov 5, 2024
backtrace-library/src/main/java/backtraceio/library/common/ApplicationHelper.java
Outdated
Show resolved
Hide resolved
backtrace-library/src/main/java/backtraceio/library/models/json/BacktraceAttributes.java
Outdated
Show resolved
Hide resolved
backtrace-library/src/main/java/backtraceio/library/models/json/ReportDataBuilder.java
Outdated
Show resolved
Hide resolved
backtrace-library/src/main/java/backtraceio/library/models/metrics/Event.java
Show resolved
Hide resolved
perf2711
reviewed
Nov 6, 2024
backtrace-library/src/main/java/backtraceio/library/models/json/ReportDataBuilder.java
Outdated
Show resolved
Hide resolved
backtrace-library/src/main/java/backtraceio/library/models/json/ReportDataBuilder.java
Outdated
Show resolved
Hide resolved
perf2711
reviewed
Nov 7, 2024
backtrace-library/src/main/java/backtraceio/library/common/ApplicationMetadataCache.java
Outdated
Show resolved
Hide resolved
backtrace-library/src/main/java/backtraceio/library/models/attributes/ReportDataBuilder.java
Outdated
Show resolved
Hide resolved
backtrace-library/src/main/java/backtraceio/library/common/ApplicationMetadataCache.java
Outdated
Show resolved
Hide resolved
backtrace-library/src/main/java/backtraceio/library/services/BacktraceMetrics.java
Outdated
Show resolved
Hide resolved
backtrace-library/src/main/java/backtraceio/library/services/BacktraceMetrics.java
Show resolved
Hide resolved
backtrace-library/src/main/java/backtraceio/library/common/ApplicationMetadataCache.java
Show resolved
Hide resolved
backtrace-library/src/main/java/backtraceio/library/common/ApplicationMetadataCache.java
Outdated
Show resolved
Hide resolved
backtrace-library/src/main/java/backtraceio/library/common/DeviceAttributesHelper.java
Show resolved
Hide resolved
backtrace-library/src/main/java/backtraceio/library/models/Tuple.java
Outdated
Show resolved
Hide resolved
backtrace-library/src/main/java/backtraceio/library/models/attributes/ReportDataAttributes.java
Outdated
Show resolved
Hide resolved
backtrace-library/src/main/java/backtraceio/library/models/attributes/ReportDataBuilder.java
Outdated
Show resolved
Hide resolved
backtrace-library/src/main/java/backtraceio/library/common/ApplicationMetadataCache.java
Show resolved
Hide resolved
backtrace-library/src/main/java/backtraceio/library/common/ApplicationMetadataCache.java
Show resolved
Hide resolved
backtrace-library/src/main/java/backtraceio/library/common/ApplicationMetadataCache.java
Show resolved
Hide resolved
BartoszLitwiniuk
approved these changes
Nov 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
perf2711
approved these changes
Nov 13, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Attribute generations .... cost us time. We generated them multiple times during metrics setup AND metrics payload generation. In addition to that we had a situation where we generated attributes twice during single object creation (in the constructor to get an application name and later to get all attributes for payload)
This pull request significantly improves the performance of the metrics system - my internal results give me 2x time reduction. Other parts of our system can also benefit from it - everything that uses our attribute system should retrieve results faster.
ref: BT-2660