Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creating File entities with new File() does not populate filename and filemime #1938

Closed
quicksketch opened this issue May 27, 2016 · 1 comment
Closed

Creating File entities with new File() does not populate filename and filemime #1938

quicksketch opened this issue May 27, 2016 · 1 comment
Assignees
@quicksketch
Labels
status - fixed type - bug report
Milestone
1.4.3

Comments

@quicksketch
Copy link
Member

I recently had a test failure caused by switching from $file = entity_create('file') to $file = new File(). These two calls should be equivalent, but it appears that the FileStorageController is doing some extra work populating the filename and filemime properties. This should be moved to the File::__construct() method so that it is called using either method.
@quicksketch quicksketch added this to the 1.4.3 milestone May 27, 2016
@quicksketch quicksketch self-assigned this May 27, 2016
@quicksketch quicksketch mentioned this issue May 27, 2016
Merged
@quicksketch
Copy link
Member Author

PR filed at backdrop/backdrop#1420.

@quicksketch quicksketch mentioned this issue May 27, 2016
Closed
backdrop-ci referenced this issue in backdrop/backdrop May 27, 2016
@quicksketch
Issue #1938: Moving new file preparation to constructor.
a83158e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@quicksketch quicksketch

Labels
status - fixed type - bug report
Projects
None yet
Milestone
1.4.3
Development

No branches or pull requests
2 participants
@quicksketch @jenlampton