-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve PHP code inspection warnings and errors in core /includes directory #1937
Comments
PR filed at backdrop/backdrop#1419. |
While fixing a PHP inspection warning in file.inc, I ran across a bug in creating new file entities. New issue at #1938. |
Merged in backdrop/backdrop#1419, it's only fixing a small (but critical) part of the documentation in Backdrop core, but it reduces the inspection warnings substantially. This will be in 1.4.3. |
👏 for reducing annoyances. |
I found that PHP 7's error handling doesn't work quite right with one of these changes. We made it so that |
Merged backdrop/backdrop#1431. Again for 1.4.3. |
Similar to #1868, this issue is to resolve PHP inspection warnings and errors in the entire /core/includes directory. This includes fixing things like the following:
@return
values are accurate and interpreted correctly from callers.This sort of checking reduces the errors reported by PHPStorm and other IDEs, allowing their inspection abilities to appropriately flag real problems in our code base. It also helps with autocompletion. And of course it should result in more complete and accurate documentation for real users reading the code or the docs on api.backdropcms.org.
The text was updated successfully, but these errors were encountered: