Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ruamel-yaml as a dependency #246

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Remove ruamel-yaml as a dependency #246

merged 1 commit into from
Nov 30, 2023

Conversation

bachya
Copy link
Owner

@bachya bachya commented Nov 30, 2023

Describe what the PR does:

Turns out, we don't need it.

Does this fix a specific issue?

N/A

Checklist:

  • Confirm that one or more new tests are written for the new functionality.
  • Run tests and ensure everything passes (with 100% test coverage).
  • Update README.md with any new documentation.

@bachya bachya added the dependencies Upgrade or downgrade of project dependencies label Nov 30, 2023
@bachya bachya self-assigned this Nov 30, 2023
Copy link

codecov bot commented Nov 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (501f2f5) 100.00% compared to head (31b813f) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##               dev      #246   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          235       235           
=========================================
  Hits           235       235           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bachya bachya merged commit 4d63b77 into dev Nov 30, 2023
11 of 12 checks passed
@bachya bachya deleted the ruamel branch November 30, 2023 18:46
@github-actions github-actions bot locked and limited conversation to collaborators Dec 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Upgrade or downgrade of project dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant