Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create podspec. Reconfigure the project for Carthage, Xcode support and CI. #7

Merged
merged 4 commits into from
Oct 18, 2017

Conversation

andersio
Copy link
Contributor

@andersio andersio commented Oct 16, 2017

Fixes #4

  1. Create a podspec.

  2. Reconfigure the ReactiveFeedback framework to be a universal framework scheme that supports iOS 8.0+, macOS 10.9+, watchOS 2.0+ and tvOS 9.0+.

Sadly, Carthage was pulled in for the development environment in because CocoaPods refuses to yield per platform framework targets for the same pod. 💁‍♂️

@andersio andersio force-pushed the anders/podspec branch 7 times, most recently from 96b07da to bd8411b Compare October 17, 2017 03:01
@andersio andersio changed the title Create podspec. Reconfigure the project for Carthage & Xcode support. Create podspec. Reconfigure the project for Carthage, Xcode support and CI. Oct 17, 2017
@andersio andersio force-pushed the anders/podspec branch 3 times, most recently from e8d80d7 to b936a2a Compare October 17, 2017 03:25
@sergdort
Copy link
Contributor

I think we just need to make several development frameworks e.g ReactiveFeedback-iOS, ReactiveFeedback-tvOS etc. And make the same module name for all

Copy link
Contributor

@sergdort sergdort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH I'm against using Carthage for development as it requires additional steps to play with it.
Also, I'm pretty sure that not all developers have Carthage installed, like me :)

@andersio
Copy link
Contributor Author

So should we use CocoaPods? Or just git submodules?

@sergdort
Copy link
Contributor

Not sure, TBH I've never used git submodules

@RuiAAPeres
Copy link
Contributor

Cocoapods + Carthage?

@andersio
Copy link
Contributor Author

andersio commented Oct 17, 2017

@RuiAAPeres We already support both, plus those who use the Xcode project directly. The question is what workspace i.e. the example app and the test targets should use.

I think we just need to make several development frameworks e.g ReactiveFeedback-iOS, ReactiveFeedback-tvOS etc.

@sergdort If you mean doing this for CocoaPods, that would tie the framework target with CocoaPods. I have tried declaring abstract target per platform, and CocoaPods just create an iOS target (for the example app). :S

@andersio
Copy link
Contributor Author

andersio commented Oct 17, 2017

https://github.com/Moya/Moya
^ Similar example: Moya

Edit: https://github.com/RxSwiftCommunity/RxDataSources
^ This seems to be a way to support both Carthage & CocoaPods.

@andersio
Copy link
Contributor Author

andersio commented Oct 17, 2017

So now it should support both CocoaPods and Carthage for development. I guess it should be sufficient given our example sets would probably remain iOS exclusive, and the framework would hardly have platform specific logic by its nature.

@sergdort
Copy link
Contributor

LGTM 👍

@andersio andersio merged commit e1b6ced into develop Oct 18, 2017
@andersio andersio deleted the anders/podspec branch October 18, 2017 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants