-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create podspec. Reconfigure the project for Carthage, Xcode support and CI. #7
Conversation
96b07da
to
bd8411b
Compare
e8d80d7
to
b936a2a
Compare
b936a2a
to
729a1bf
Compare
I think we just need to make several development frameworks e.g |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TBH I'm against using Carthage
for development as it requires additional steps to play with it.
Also, I'm pretty sure that not all developers have Carthage
installed, like me :)
So should we use CocoaPods? Or just git submodules? |
Not sure, TBH I've never used |
Cocoapods + Carthage? |
@RuiAAPeres We already support both, plus those who use the Xcode project directly. The question is what workspace i.e. the example app and the test targets should use.
@sergdort |
https://github.com/Moya/Moya Edit: https://github.com/RxSwiftCommunity/RxDataSources |
So now it should support both CocoaPods and Carthage for development. I guess it should be sufficient given our example sets would probably remain iOS exclusive, and the framework would hardly have platform specific logic by its nature. |
LGTM 👍 |
dcd6424
to
d7ab53b
Compare
Fixes #4
Create a podspec.
Reconfigure the ReactiveFeedback framework to be a universal framework scheme that supports iOS 8.0+, macOS 10.9+, watchOS 2.0+ and tvOS 9.0+.
Sadly, Carthage was pulled in for the development environment in because CocoaPods refuses to yield per platform framework targets for the same pod. 💁♂️