Xcode 10 compatibility #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andersio
force-pushed
the
anders/split-framework
branch
from
1e7a7b2 to
1c81009
Compare
RuiAAPeres
approved these changes
Oct 28, 2018
andersio
force-pushed
the
anders/split-framework
branch
from
3845810 to
3ace4b7
Compare
zzcgumn
approved these changes
Oct 29, 2018
mluisbrown
approved these changes
Oct 29, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits the universal framework target into three platform specific targets.
RAF was using a universal framework target, which is apparently not working well with the new build system enabled in Xcode 10. Specifically, the build system has issues in discovering dependencies & attributing them with the correct platform.