Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Public Feedback primitive initialiser. #17

Merged
merged 1 commit into from
Nov 19, 2017
Merged

Public Feedback primitive initialiser. #17

merged 1 commit into from
Nov 19, 2017

Conversation

andersio
Copy link
Contributor

@andersio andersio commented Nov 7, 2017

This initialiser is useful when one has event sources that should stay alive across multiple states.

@RuiAAPeres
Copy link
Contributor

broken ci

@andersio andersio force-pushed the anders/public-feedback-init branch from 6feea7e to e408616 Compare November 19, 2017 16:34
@andersio andersio force-pushed the anders/public-feedback-init branch from e408616 to 5e9c851 Compare November 19, 2017 16:36
sergdort
sergdort approved these changes Nov 19, 2017
View reviewed changes
Copy link
Contributor

@sergdort sergdort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@RuiAAPeres RuiAAPeres merged commit c6ba92b into develop Nov 19, 2017
@RuiAAPeres RuiAAPeres deleted the anders/public-feedback-init branch November 19, 2017 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergdort sergdort sergdort approved these changes

Assignees
No one assigned
Labels
enhancement ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andersio @RuiAAPeres @sergdort