DrawerKit 0.4.1 release #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rred from the existence or not of a handle configuration instance.
…w-bug-fixes # Conflicts: # DrawerKit/DrawerKit/Internal API/PresentationController+Properties.swift
zzcgumn
reviewed
Nov 27, 2017
| @@ -343,7 +343,7 @@ | |||
| GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE; | |||
| GCC_WARN_UNUSED_FUNCTION = YES; | |||
| GCC_WARN_UNUSED_VARIABLE = YES; | |||
| IPHONEOS_DEPLOYMENT_TARGET = 10.3; | |||
| IPHONEOS_DEPLOYMENT_TARGET = 10.2; | |||
There was a problem hiding this comment.
Yes. It makes it easier to test DrawerKit in the simulator.
zzcgumn
reviewed
Nov 27, 2017
| let controller = presentedVC.presentationController as! PresentationController | ||
| controller.intermediate.view.addSubview(presentedVC.view) | ||
| } | ||
| if isPresentation { transitionContext.containerView.addSubview(presentedVC.view) } |
There was a problem hiding this comment.
Our normal coding style is
if condition {
do something
}
also for simple one-liners.
zzcgumn
previously approved these changes
Nov 27, 2017
zzcgumn
approved these changes
Nov 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverses the fix for the issue about safe areas. The fix broke other things (even caused crashes in certain scenarios) and the issue will need to be re-opened.
Changes the minimum deployment target to 10.2.