Use a container VC to make sure UIKit owned insets do not go wild. #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wltrup
suggested changes
Nov 24, 2017
| @@ -21,11 +21,11 @@ private extension PresenterViewController { | |||
| // what you need to configure differently. They're all listed here just so you | |||
| // can see what can be configured. The values listed are the default ones, | |||
| // except where indicated otherwise. | |||
| configuration.totalDurationInSeconds = 3 // default is 0.4 | |||
| configuration.totalDurationInSeconds = 0.4//3 // default is 0.4 | |||
There was a problem hiding this comment.
I'd suggest to remove the //3 part.
| configuration.durationIsProportionalToDistanceTraveled = false | ||
| // default is UISpringTimingParameters() | ||
| configuration.timingCurveProvider = UISpringTimingParameters(dampingRatio: 0.8) | ||
| configuration.fullExpansionBehaviour = .leavesCustomGap(gap: 100) // default is .coversFullScreen | ||
| configuration.fullExpansionBehaviour = .coversFullScreen//.leavesCustomGap(gap: 100) // default is .coversFullScreen |
There was a problem hiding this comment.
I'd suggest to remove the //.leavesCustomGap(gap: 100) part.
andersio
force-pushed
the
anders/system-top-insets
branch
from
4264092 to
0b34c0d
Compare
andersio
force-pushed
the
anders/system-top-insets
branch
from
0b34c0d to
cb357d7
Compare
wltrup
approved these changes
Nov 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #31.
TL;DR
If the drawer content is laid out against (1) safe area top or (2) top layout guide, these are now in effect throughout the entire presentation time, regardless of the drawer being fully expanded or not.
Details
The safe area mechanism (and its earlier variant
(top|bottom)LayoutGuide) appears to be dependent on the view origin. If the view does not lie at (0, 0) of the screen, UIKit would not consider the view overlapping with top system bars, thus having a safe area top inset of zero (or top layout guide length).Jeez. ZERO.
Fortunately, child VCs inherit safe area insets (and layout guides) from their parent VCs. So a full-screen transparent container VC is added. This container VC manages the presented drawer, so that the drawer now gets system layout insets at all phases of presentation. 💁♂️
Note
This PR makes the drawer content in the Demo app layouts against the top layout guide.
GIF