DrawerKit release 0.1 #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d some refactoring.
… Still not a perfect solution because the animator's completion block is, surprisingly, not always called. Apparently, that's a bug in UIViewPropertyAnimator.
…y doesn't like `guard` with boolean statements. ;)
…adius would not be set to zero because the property animator's completion would not always be called. Now we force it to zero on presentationTransitionDidEnd() (for the appropriate drawer ending positions).
…er are now given in absolute rather than relative terms.
…pod lib lint the pod.
…on animation doesn't complete, therefore not invoking viewDidAppear, which causes the drawer not to show up at all. The work-around means that the initial presentation and dismissal aren't interactive but Product signed off on that decision. The drawers work fine under iOS 11.
…xcuse to turn CI off since DrawerKit fails it for lack of configuration for testing.
Introducing DrawerKit
* Added CircleCI config file. * Changed circle.yml to "test" with the simulator, which disables testing * Let's try this one more time, shall we? * And again * Fixed circle.yml * And again * Fixed circle.yml * Fixed circle.yml. * Added CircleCI badge to README. * Simplified circle.yml build command. * Added dependency management commands to circle.yml
* Fixed podspec source item. * Missed the s in https.
* Added git ignore file * Added project workspace * Added tab bar template project * Added DrawerKit empty framework * Added basic view controllers and storyboards * Fixed broken outlets * Added implementation of DrawerKit. A few bits to complete still. * Hooked up the view controllers to the custom presentation. * Added clamping to the three possible resting positions of the drawer * Added more configuration to the presenting VC * Fixed a few glitches related to allowing partial expansion or not, and some refactoring. * Removed the two timing configurations and now using only one for all animations. * Added support for not having the gesture recognisers. * Fixed a potential division by zero. * Adding more configuration controls to presenting VC. WIP. * Added debug mode. * Added some TODOs * Renamed a function to make it clear it's a debugging feature. * Minor refactoring. * Renamed some source files for better clarity of intention. * Removed source headers. * Changed the presented VC to make a larger drawer (easier to play with). * Changed some parameters as per Sam's input. * Improved behaviour of corner rounding at the two edges of the screen. Still not a perfect solution because the animator's completion block is, surprisingly, not always called. Apparently, that's a bug in UIViewPropertyAnimator. * Made the logic for the drawer behaviour easier to read, because Sergey doesn't like `guard` with boolean statements. ;) * Moved some code closer to where it's actually used. * Minor formatting. * Added a fix to the corner-radius animation issue whereby the corner radius would not be set to zero because the property animator's completion would not always be called. Now we force it to zero on presentationTransitionDidEnd() (for the appropriate drawer ending positions). * Disabled automatic code signing. * The heights of the bands surrounding the resting position of the drawer are now given in absolute rather than relative terms. * Oopsie... committed a compiler error. Fixed now. * Added a scrollview to the presented view controller in the demo app, for testing how scrolling interacts with the drag gesture recogniser in the presentation controller. * Added an interaction controller, the first step in fixing the non-interactive presentation/dismissal itself. * Renamed TransitionAnimator to AnimationController. * Renamed a file to match the extension it's about. * Duh, it was supposed to be AnimationController, not AnimatorController. * Implemented interactive controller for the presentation and dismissal, and cleaned up the code for the animation controller (it doesn't need to know anything about the drawers). * Added license file and CocoaPods podspec. Not passing lint just yet. * Removed indirect access to configuration parameters. * Removed currently unused source file TransitionGeometry. * Fixed company name in the license file. * Cleared the team entry in the demo app. * Demo app: adding controls for all the configurable parameters. WIP. * Added control for manipulating cubic Bezier control points, CubicBezierView. * Added all the controls to the presenter VC. * Fixed a TODO comment. * Make sure that durationInSeconds is a positive value. * Removed all references to coversStatusBar since that hasn't been implemented yet. * Make sure that flickSpeedThreshold is a non-negative value. Also, if zero, disables support for flicking. * Make sure that upperMarkGap and lowerMarkGap are non-negative values. * Only add debugging mark lines if at least one of upperMarkGap and lowerMarkGap is a positive value. * Make sure that maximumCornerRadius is a non-negative value. * Only animate the corner radius if maximumCornerRadius is strictly positive. * Make sure that numberOfTapsForOutsideDrawerDismissal is a non-negative value. * Resolved an issue with animating rounding the presented view corners. * Simplified the demo app to its bare essentials. No more configuration controls to the wazoo. * Added based documentation to the library. * Preliminary version of README. WIP. * Removed unused assets. * Added some pseudo-code to the README, to explain the presentation/dismissal logic. * Code style change. * Removed unnecessary [weak self] capture lists. * Changed default value of durationInSeconds from 0.8 to 0.3 seconds. * Fixed a botched global search/replace in DrawerConfiguration+Equatable. * Renamed evil local gr variables to less evil names. * Fixed guard statements as per comments. * Removed a comment. * Removed a protocol extension. * Make sure that the height of the partially expanded drawer is non-negative. * Added documentation to all exposed public entities. * Style change as per comments. * Fixed documentation. * Updated README file. * Tweaked the README file. * Decreased the deployment target requirement, from 10.3 to 10.0. * Removed hidden extension in the LICENSE file. * Fixed source_files entry in the podspec. Removed the exclude_files entry. * Added a .swift-version file with the appropriate version of Swift to pod lib lint the pod. * Fixed the homepage in the podspec. * Fixed a bug when running under iOS 10 in which the initial presentation animation doesn't complete, therefore not invoking viewDidAppear, which causes the drawer not to show up at all. The work-around means that the initial presentation and dismissal aren't interactive but Product signed off on that decision. The drawers work fine under iOS 11. * Style change. * Killed the use of IUO references. * Changed author email address in the podspec. * Added support for Carthage. * [ci skip] Removed a commented out section from the README. Also, an excuse to turn CI off since DrawerKit fails it for lack of configuration for testing. * Added CircleCI config file. (#9) * Added CircleCI config file. * Changed circle.yml to "test" with the simulator, which disables testing * Let's try this one more time, shall we? * And again * Fixed circle.yml * And again * Fixed circle.yml * Fixed circle.yml. * Added CircleCI badge to README. * Simplified circle.yml build command. * Added dependency management commands to circle.yml * Fixed podspec source item. (#12) * Fixed podspec source item. * Missed the s in https.
* Adds a gif and fixes the circleci badge. * Moved the gif down a bit. * Removed extra space below the gif.
diegopetrucci
approved these changes
Oct 17, 2017
wltrup
added a commit
that referenced
this pull request
Oct 17, 2017
* Added git ignore file * Added project workspace * Added tab bar template project * Added DrawerKit empty framework * Added basic view controllers and storyboards * Fixed broken outlets * Added implementation of DrawerKit. A few bits to complete still. * Hooked up the view controllers to the custom presentation. * Added clamping to the three possible resting positions of the drawer * Added more configuration to the presenting VC * Fixed a few glitches related to allowing partial expansion or not, and some refactoring. * Removed the two timing configurations and now using only one for all animations. * Added support for not having the gesture recognisers. * Fixed a potential division by zero. * Adding more configuration controls to presenting VC. WIP. * Added debug mode. * Added some TODOs * Renamed a function to make it clear it's a debugging feature. * Minor refactoring. * Renamed some source files for better clarity of intention. * Removed source headers. * Changed the presented VC to make a larger drawer (easier to play with). * Changed some parameters as per Sam's input. * Improved behaviour of corner rounding at the two edges of the screen. Still not a perfect solution because the animator's completion block is, surprisingly, not always called. Apparently, that's a bug in UIViewPropertyAnimator. * Made the logic for the drawer behaviour easier to read, because Sergey doesn't like `guard` with boolean statements. ;) * Moved some code closer to where it's actually used. * Minor formatting. * Added a fix to the corner-radius animation issue whereby the corner radius would not be set to zero because the property animator's completion would not always be called. Now we force it to zero on presentationTransitionDidEnd() (for the appropriate drawer ending positions). * Disabled automatic code signing. * The heights of the bands surrounding the resting position of the drawer are now given in absolute rather than relative terms. * Oopsie... committed a compiler error. Fixed now. * Added a scrollview to the presented view controller in the demo app, for testing how scrolling interacts with the drag gesture recogniser in the presentation controller. * Added an interaction controller, the first step in fixing the non-interactive presentation/dismissal itself. * Renamed TransitionAnimator to AnimationController. * Renamed a file to match the extension it's about. * Duh, it was supposed to be AnimationController, not AnimatorController. * Implemented interactive controller for the presentation and dismissal, and cleaned up the code for the animation controller (it doesn't need to know anything about the drawers). * Added license file and CocoaPods podspec. Not passing lint just yet. * Removed indirect access to configuration parameters. * Removed currently unused source file TransitionGeometry. * Fixed company name in the license file. * Cleared the team entry in the demo app. * Demo app: adding controls for all the configurable parameters. WIP. * Added control for manipulating cubic Bezier control points, CubicBezierView. * Added all the controls to the presenter VC. * Fixed a TODO comment. * Make sure that durationInSeconds is a positive value. * Removed all references to coversStatusBar since that hasn't been implemented yet. * Make sure that flickSpeedThreshold is a non-negative value. Also, if zero, disables support for flicking. * Make sure that upperMarkGap and lowerMarkGap are non-negative values. * Only add debugging mark lines if at least one of upperMarkGap and lowerMarkGap is a positive value. * Make sure that maximumCornerRadius is a non-negative value. * Only animate the corner radius if maximumCornerRadius is strictly positive. * Make sure that numberOfTapsForOutsideDrawerDismissal is a non-negative value. * Resolved an issue with animating rounding the presented view corners. * Simplified the demo app to its bare essentials. No more configuration controls to the wazoo. * Added based documentation to the library. * Preliminary version of README. WIP. * Removed unused assets. * Added some pseudo-code to the README, to explain the presentation/dismissal logic. * Code style change. * Removed unnecessary [weak self] capture lists. * Changed default value of durationInSeconds from 0.8 to 0.3 seconds. * Fixed a botched global search/replace in DrawerConfiguration+Equatable. * Renamed evil local gr variables to less evil names. * Fixed guard statements as per comments. * Removed a comment. * Removed a protocol extension. * Make sure that the height of the partially expanded drawer is non-negative. * Added documentation to all exposed public entities. * Style change as per comments. * Fixed documentation. * Updated README file. * Tweaked the README file. * Decreased the deployment target requirement, from 10.3 to 10.0. * Removed hidden extension in the LICENSE file. * Fixed source_files entry in the podspec. Removed the exclude_files entry. * Added a .swift-version file with the appropriate version of Swift to pod lib lint the pod. * Fixed the homepage in the podspec. * Fixed a bug when running under iOS 10 in which the initial presentation animation doesn't complete, therefore not invoking viewDidAppear, which causes the drawer not to show up at all. The work-around means that the initial presentation and dismissal aren't interactive but Product signed off on that decision. The drawers work fine under iOS 11. * Style change. * Killed the use of IUO references. * Changed author email address in the podspec. * Added support for Carthage. * [ci skip] Removed a commented out section from the README. Also, an excuse to turn CI off since DrawerKit fails it for lack of configuration for testing. * Added CircleCI config file. (#9) * Added CircleCI config file. * Changed circle.yml to "test" with the simulator, which disables testing * Let's try this one more time, shall we? * And again * Fixed circle.yml * And again * Fixed circle.yml * Fixed circle.yml. * Added CircleCI badge to README. * Simplified circle.yml build command. * Added dependency management commands to circle.yml * Fixed podspec source item. (#12) * Fixed podspec source item. * Missed the s in https. * DrawerKit release 0.0.1 (#13) (#14) * Added git ignore file * Added project workspace * Added tab bar template project * Added DrawerKit empty framework * Added basic view controllers and storyboards * Fixed broken outlets * Added implementation of DrawerKit. A few bits to complete still. * Hooked up the view controllers to the custom presentation. * Added clamping to the three possible resting positions of the drawer * Added more configuration to the presenting VC * Fixed a few glitches related to allowing partial expansion or not, and some refactoring. * Removed the two timing configurations and now using only one for all animations. * Added support for not having the gesture recognisers. * Fixed a potential division by zero. * Adding more configuration controls to presenting VC. WIP. * Added debug mode. * Added some TODOs * Renamed a function to make it clear it's a debugging feature. * Minor refactoring. * Renamed some source files for better clarity of intention. * Removed source headers. * Changed the presented VC to make a larger drawer (easier to play with). * Changed some parameters as per Sam's input. * Improved behaviour of corner rounding at the two edges of the screen. Still not a perfect solution because the animator's completion block is, surprisingly, not always called. Apparently, that's a bug in UIViewPropertyAnimator. * Made the logic for the drawer behaviour easier to read, because Sergey doesn't like `guard` with boolean statements. ;) * Moved some code closer to where it's actually used. * Minor formatting. * Added a fix to the corner-radius animation issue whereby the corner radius would not be set to zero because the property animator's completion would not always be called. Now we force it to zero on presentationTransitionDidEnd() (for the appropriate drawer ending positions). * Disabled automatic code signing. * The heights of the bands surrounding the resting position of the drawer are now given in absolute rather than relative terms. * Oopsie... committed a compiler error. Fixed now. * Added a scrollview to the presented view controller in the demo app, for testing how scrolling interacts with the drag gesture recogniser in the presentation controller. * Added an interaction controller, the first step in fixing the non-interactive presentation/dismissal itself. * Renamed TransitionAnimator to AnimationController. * Renamed a file to match the extension it's about. * Duh, it was supposed to be AnimationController, not AnimatorController. * Implemented interactive controller for the presentation and dismissal, and cleaned up the code for the animation controller (it doesn't need to know anything about the drawers). * Added license file and CocoaPods podspec. Not passing lint just yet. * Removed indirect access to configuration parameters. * Removed currently unused source file TransitionGeometry. * Fixed company name in the license file. * Cleared the team entry in the demo app. * Demo app: adding controls for all the configurable parameters. WIP. * Added control for manipulating cubic Bezier control points, CubicBezierView. * Added all the controls to the presenter VC. * Fixed a TODO comment. * Make sure that durationInSeconds is a positive value. * Removed all references to coversStatusBar since that hasn't been implemented yet. * Make sure that flickSpeedThreshold is a non-negative value. Also, if zero, disables support for flicking. * Make sure that upperMarkGap and lowerMarkGap are non-negative values. * Only add debugging mark lines if at least one of upperMarkGap and lowerMarkGap is a positive value. * Make sure that maximumCornerRadius is a non-negative value. * Only animate the corner radius if maximumCornerRadius is strictly positive. * Make sure that numberOfTapsForOutsideDrawerDismissal is a non-negative value. * Resolved an issue with animating rounding the presented view corners. * Simplified the demo app to its bare essentials. No more configuration controls to the wazoo. * Added based documentation to the library. * Preliminary version of README. WIP. * Removed unused assets. * Added some pseudo-code to the README, to explain the presentation/dismissal logic. * Code style change. * Removed unnecessary [weak self] capture lists. * Changed default value of durationInSeconds from 0.8 to 0.3 seconds. * Fixed a botched global search/replace in DrawerConfiguration+Equatable. * Renamed evil local gr variables to less evil names. * Fixed guard statements as per comments. * Removed a comment. * Removed a protocol extension. * Make sure that the height of the partially expanded drawer is non-negative. * Added documentation to all exposed public entities. * Style change as per comments. * Fixed documentation. * Updated README file. * Tweaked the README file. * Decreased the deployment target requirement, from 10.3 to 10.0. * Removed hidden extension in the LICENSE file. * Fixed source_files entry in the podspec. Removed the exclude_files entry. * Added a .swift-version file with the appropriate version of Swift to pod lib lint the pod. * Fixed the homepage in the podspec. * Fixed a bug when running under iOS 10 in which the initial presentation animation doesn't complete, therefore not invoking viewDidAppear, which causes the drawer not to show up at all. The work-around means that the initial presentation and dismissal aren't interactive but Product signed off on that decision. The drawers work fine under iOS 11. * Style change. * Killed the use of IUO references. * Changed author email address in the podspec. * Added support for Carthage. * [ci skip] Removed a commented out section from the README. Also, an excuse to turn CI off since DrawerKit fails it for lack of configuration for testing. * Added CircleCI config file. (#9) * Added CircleCI config file. * Changed circle.yml to "test" with the simulator, which disables testing * Let's try this one more time, shall we? * And again * Fixed circle.yml * And again * Fixed circle.yml * Fixed circle.yml. * Added CircleCI badge to README. * Simplified circle.yml build command. * Added dependency management commands to circle.yml * Fixed podspec source item. (#12) * Fixed podspec source item. * Missed the s in https. * Add gif and fixes the circle CI badge. (#17) * Adds a gif and fixes the circleci badge. * Moved the gif down a bit. * Removed extra space below the gif. * Changes version from 0.0.1 to 0.1. (#18)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No functional changes. Only adds a gif to the README file and fixes the circle CI badge on it.