Merge pull request evt-project#104 from evt-project/bugfix/addition-w…

…ithout-place Fix AdditionParser when element does not have a place attribute
babsevensix · Nov 27, 2020 · 15f741c · 15f741c
2 parents 237559b + 49fba39
commit 15f741c
Showing 1 changed file with 2 additions and 7 deletions.
diff --git a/src/app/services/xml-parsers/basic-parsers.ts b/src/app/services/xml-parsers/basic-parsers.ts
@@ -224,15 +224,10 @@ export class GapParser extends EmptyParser implements Parser<XMLElement> {
 export class AdditionParser extends EmptyParser implements Parser<XMLElement> {
     elementParser = createParser(ElementParser, this.genericParse);
     attributeParser = createParser(AttributeParser, this.genericParse);
-    parse(xml: XMLElement): Addition | GenericElement {
-        const place = xml.getAttribute('place') as PlacementType;
-        if (!place) {
-            return this.elementParser.parse(xml);
-        }
-
+    parse(xml: XMLElement): Addition {
         return {
             type: Addition,
-            place,
+            place: xml.getAttribute('place') as PlacementType,
             path: xpath(xml),
             content: parseChildren(xml, this.genericParse),
             attributes: this.attributeParser.parse(xml),