Skip to content
This repository has been archived by the owner on Apr 19, 2021. It is now read-only.

Remove Tailwind CSS UI and updated deps. #5

Merged
merged 2 commits into from
May 3, 2020

Conversation

wildpow
Copy link
Contributor

@wildpow wildpow commented May 3, 2020

Remove Tailwind UI

  • I believe this is a pay-for project which would be of no use for most people using this starter.

Update Dependencies

  • Minor version bump to Svelte.
  • Minor version bump to PostCSS.
  • Major update to Rollup from v1 to v2.

NOTE
  • @rollup/plugin-commonjs was not updated due to issue 1151.

wildpow added 2 commits May 3, 2020 12:32
I beleive this is a pay for package and no use for most using this starter.
PostCSS minor version bump
Svelte minor version bump
Rollup major update to version ^2.7
Note:
`@rollup/plugin-commonjs` was not updated due to issue with sapper:
sveltejs/sapper#1151
@wildpow
Copy link
Contributor Author

wildpow commented May 3, 2020

Tested dev, prod and export scripts. The only difference I saw was the console warning

> To preserve the export signature of the entry module "src/client.js", an empty
 facade chunk was created. This often happens when creating a bundle for a 
web app where chunks are placed in script tags and exports are ignored. 
In this case it is recommended to set "preserveEntrySignatures: false"
 to avoid this and reduce the number of chunks. Otherwise if this is intentional,
 set "preserveEntrySignatures: 'strict'" explicitly to silence this warning.

I found a merged Rollup PR 3498 but, nothing else to indicate this being a show stopper.

Copy link
Owner

@babichjacob babichjacob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Tailwind UI plugin provides colors and other extensions to Tailwind CSS that will make their way into a future update (i.e. are free for everyone).

Adam confirming this

This is different from the (paid) Tailwind UI package of HTML components, which is dependent on the Tailwind UI plugin (or using the CDN build of it).

Because the plugin is currently commented out in tailwind.config.js because I haven't figured out why there is a recursion error using it during development (but not production), I will approve these changes anyway.

@babichjacob
Copy link
Owner

Tested dev, prod and export scripts. The only difference I saw was the console warning

> To preserve the export signature of the entry module "src/client.js", an empty
 facade chunk was created. This often happens when creating a bundle for a 
web app where chunks are placed in script tags and exports are ignored. 
In this case it is recommended to set "preserveEntrySignatures: false"
 to avoid this and reduce the number of chunks. Otherwise if this is intentional,
 set "preserveEntrySignatures: 'strict'" explicitly to silence this warning.

I found a merged Rollup PR 3498 but, nothing else to indicate this being a show stopper.

Right, it's fine. The other template has moved to Rollup v2 with no trouble. Maybe it'll be possible to silence this warning in onwarn in rollup.config.js.

@babichjacob babichjacob merged commit 8c8c4fe into babichjacob:master May 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants