Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] File Name Extension Add #1673

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions .idea/codeStyles/Project.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions .idea/codeStyles/codeStyleConfig.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions .idea/inspectionProfiles/Project_Default.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions .idea/misc.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 8 additions & 0 deletions .idea/modules.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions .idea/vcs.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 12 additions & 0 deletions .idea/website.iml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

241 changes: 241 additions & 0 deletions .idea/workspace.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions docs/parser.md
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,7 @@ require("@babel/parser").parse("code", {
> NOTE: When a plugin is specified multiple times, only the first options are considered.

- `decorators`:
- `decoratorsBeforeExport` (`boolean`)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm why is this change here?

- `decoratorsBeforeExport` (`boolean`, default: `false`)
```js
// decoratorsBeforeExport: true
Expand Down
2 changes: 2 additions & 0 deletions js/repl/Repl.js
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ type State = {
pluginSearch: ?string,
showOfficialExternalPlugins: boolean,
loadingExternalPlugins: boolean,
filename: ?string,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to add the setting to the state initializer similar to https://github.com/babel/website/pull/1676/files#diff-13734ac24709204bbae97c4b659d1ba1R149

};

const DEBOUNCE_DELAY = 500;
Expand Down Expand Up @@ -221,6 +222,7 @@ class Repl extends React.Component<Props, State> {
}
showOfficialExternalPlugins={state.showOfficialExternalPlugins}
loadingExternalPlugins={state.loadingExternalPlugins}
filename={state.filename}
/>

<div className={styles.panels}>
Expand Down
Loading