-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core-packages pages #1026
Core-packages pages #1026
Conversation
@hzoo @existentialism What are your thought about this ? I will then move/link some pages from babel/babel.github.io to babel/babel. |
|
||
## Other packages | ||
|
||
* [Types](types): Babel Types is a Lodash-esque utility library for AST nodes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can call it the package name if it's better - and does that link work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a relative link (points to docs/core-packages/types
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think it should be babel-types
or types
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did prefix all package in c9a8804
Might not need to solve this now, but some things to think about as we establish more consistency across docs:
Otherwise LGTM, nice work! |
Docs have a lot of inconsistency yeah - kinda wish we could lint (I know there's a few markdown linters) |
It would be great to lint |
yeah with a markdown AST plus custom rules 😛 I know there's https://github.com/textlint/textlint by @azu but I haven't checked it out that much |
240bf3c
to
17d6e5f
Compare
17d6e5f
to
fee6181
Compare
Merging in #1044 |
Refers to #1021.
Index page:
@hzoo The index page could replace
usage > API
(https://babeljs.io/docs/usage/api/). We can then move the doc inbabel-core
(https://github.com/babel/babel/blob/master/packages/babel-core/README.md).usage > babel-register
(https://babeljs.io/docs/usage/babel-register/) same problem.