Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include file extension in REPL config options #1666

Closed
loganfsmyth opened this issue May 23, 2018 · 4 comments · Fixed by #2117
Closed

Include file extension in REPL config options #1666

loganfsmyth opened this issue May 23, 2018 · 4 comments · Fixed by #2117

Comments

@loganfsmyth
Copy link
Member

With babel/babel#7955 Babel now allows both the flow and typescript presets to be used in parallel, and allows JSX only in .tsx, not .ts files. Given that, we'll want to stop hard-coding the filename "repl" with no extension in

filename: "repl",

Including the extension is important now, so the UI should expose that as well.

@loganfsmyth
Copy link
Member Author

We could also just expose the full filename if we want to. Depends on what kind of UX we want around this. Maybe expose the extension visibly, with a subsection that allows configuring the filename/path or something.

@AkshatSrivastava2
Copy link

@loganfsmyth I am a first-time contributor. I want to work on this issue.

@loganfsmyth
Copy link
Member Author

@AkshatSrivastava2 Go for it! Feel free to join our Slack if you want to chat and ask us questions about it. We have a channel for the website on there.

@alexzherdev
Copy link
Contributor

@AkshatSrivastava2 @loganfsmyth I can help get this to the finish line.

hackape pushed a commit to hackape/babel-repl that referenced this issue May 6, 2019
hackape pushed a commit to hackape/babel-repl that referenced this issue May 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants