This repository has been archived by the owner on Aug 4, 2020. It is now read-only.
Support optional calls in no-unused-expressions #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lehni
force-pushed
the
fix/optional-call-expression-in-no-unused-expressions
branch
from
d0f7952 to
b89ec98
Compare
kaicataldo
reviewed
Sep 4, 2018
kaicataldo
reviewed
Sep 4, 2018
|
@kaicataldo I've addressed the things in the feedback now. Please take a look. |
lehni
commented
Sep 4, 2018
|
@existentialism I've addressed all things now. Is this good to go? |
|
@lehni thanks! |
|
@existentialism great, thanks! Do you think this warrants a new release soon? Would be great! |
|
@lehni published as |
nicolo-ribaudo
pushed a commit
to babel/babel
that referenced
this pull request
Nov 14, 2019
…nal-call-expression-in-no-unused-expressions
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relates to the issue outlined here: babel/babel-eslint#643