-
-
Notifications
You must be signed in to change notification settings - Fork 258
Optional Chaining: Stage 1 plugin #545
Changes from all commits
b902fe6
1eaf016
7b51979
0927e24
b2fdd94
bc9edd1
d3bc8fc
03d89b6
51bd87b
26096d6
9bcd85a
b038600
c1702e1
2dd624b
e1ec23c
4628bb9
4c8f4a2
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -426,6 +426,18 @@ export default class Tokenizer extends LocationParser { | |
return this.finishOp(code === 61 ? tt.eq : tt.prefix, 1); | ||
} | ||
|
||
readToken_question() { // '?' | ||
const next = this.input.charCodeAt(this.state.pos + 1); | ||
const next2 = this.input.charCodeAt(this.state.pos + 2); | ||
if (next === 46 && !(next2 >= 48 && next2 <= 57)) { // '.' not followed by a number | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. what are these magic numbers? could these be stored in named variables, so it's clear what "46" means? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These are char codes. I'll add some contants to improve readability, thanks. |
||
this.state.pos += 2; | ||
return this.finishToken(tt.questionDot); | ||
} else { | ||
++this.state.pos; | ||
return this.finishToken(tt.question); | ||
} | ||
} | ||
|
||
getTokenFromCode(code: number): void { | ||
switch (code) { | ||
|
||
|
@@ -469,7 +481,7 @@ export default class Tokenizer extends LocationParser { | |
return this.finishToken(tt.colon); | ||
} | ||
|
||
case 63: ++this.state.pos; return this.finishToken(tt.question); | ||
case 63: return this.readToken_question(); | ||
case 64: ++this.state.pos; return this.finishToken(tt.at); | ||
|
||
case 96: // '`' | ||
|
@@ -917,7 +929,7 @@ export default class Tokenizer extends LocationParser { | |
const type = this.state.type; | ||
let update; | ||
|
||
if (type.keyword && prevType === tt.dot) { | ||
if (type.keyword && (prevType === tt.dot || prevType === tt.questionDot)) { | ||
this.state.exprAllowed = false; | ||
} else if (update = type.updateContext) { | ||
update.call(this, prevType); | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
new C?.() | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This test doesn't have an expected? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Doesn't parse yet, need to be implemented (i'm still WIP) |
||
|
||
new C?.(a, b) | ||
|
||
new B?.C?.() | ||
|
||
new B?.C?.(a, b) | ||
|
||
new B?.C |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could probably just move
node.optional = true;
to here since it's in all the if conditionals?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was trying to keep the property ordering consistent between optional and non-optional branches. See the
#parseNew
as well.