Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support pipeline proposal flag in @babel/parser #8291

Merged

Conversation

mAAdhaTTah
Copy link
Contributor

Q                       A
Fixed Issues? N/A
Patch: Bug Fix? No
Major: Breaking Change? Yes
Minor: New Feature? Yes
Tests Added + Pass? Yes
Documentation PR Link N/A
Any Dependency Changes? No
License MIT

Split from #8289; implements the flag to babylon so babel can move to an RC and still land that PR without shipping breaking changes. Should be easy to rebase this back into the PR.

@babel-bot
Copy link
Collaborator

babel-bot commented Jul 9, 2018

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/8553/

@nicolo-ribaudo
Copy link
Member

nicolo-ribaudo commented Jul 9, 2018

I'd prefer the validation to happen at

export function validatePlugins(plugins: PluginList) {
, so that it is checked even if the pipeline operator isn't actually used.

You can add a getPluginOption util to that file.

@mAAdhaTTah mAAdhaTTah force-pushed the add-proposal-flag-to-pipeline-parser-plugin branch 2 times, most recently from d4fdd45 to cf84792 Compare July 9, 2018 14:08
@mAAdhaTTah mAAdhaTTah force-pushed the add-proposal-flag-to-pipeline-parser-plugin branch from cf84792 to fc4ad83 Compare July 9, 2018 14:22
@mAAdhaTTah
Copy link
Contributor Author

@nicolo-ribaudo Fixed.

@hzoo hzoo merged commit 19a1705 into babel:master Jul 9, 2018
@hzoo hzoo added the PR: New Feature 🚀 A type of pull request used for our changelog categories label Jul 9, 2018
storyn26383 pushed a commit to UniSharp/babel that referenced this pull request Aug 6, 2018
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser PR: New Feature 🚀 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants