Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bebal-generator] fix: don't write ': ' token when name is null #7769

Merged
merged 1 commit into from
Apr 21, 2018

Conversation

Quramy
Copy link
Contributor

@Quramy Quramy commented Apr 21, 2018

Q                       A
Fixed Issues?
Patch: Bug Fix? 👍
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR
Any Dependency Changes?
License MIT

I found the following bug and this PR fixes it.

// @flow

// input source string
type fn = string => string;

// generated
type fn = (: string) => string;

@babel-bot
Copy link
Collaborator

babel-bot commented Apr 21, 2018

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/7656/

Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Can you wrap also the first two lines inside the if block? It would make a little bit easier to read the code.

@hzoo hzoo added the PR: Bug Fix 🐛 A type of pull request used for our changelog categories label Apr 21, 2018
@hzoo hzoo merged commit 1f97b91 into babel:master Apr 21, 2018
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants