Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc changes for https://github.com/babel/babel/issues/7063 #7185

Merged
merged 3 commits into from
Jan 9, 2018
Merged

Doc changes for https://github.com/babel/babel/issues/7063 #7185

merged 3 commits into from
Jan 9, 2018

Conversation

rajasekarm
Copy link
Member

@rajasekarm rajasekarm commented Jan 9, 2018 •
edited
Loading

Q                       A
Fixed Issues? Fixes #7063
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass?
Documentation PR Yes [skip ci]
Any Dependency Changes?
License MIT

xtuc
xtuc approved these changes Jan 9, 2018
View reviewed changes
Copy link
Member

@xtuc xtuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha! I was about to make it

@rajasekarm
Copy link
Member Author

Missed this during the actual PR.

@xtuc xtuc added the PR: Docs 📝 A type of pull request used for our changelog categories label Jan 9, 2018
@rajasekarm
Copy link
Member Author

rajasekarm commented Jan 9, 2018 •
edited
Loading

@xtuc It's in my check list, somehow I missed.

@xtuc
Copy link
Member

xtuc commented Jan 9, 2018

In an actual/expected test

You didn't change it but it's ok to me, it wouldn't make sense otherwise.

@existentialism
Copy link
Member

Some other places:
https://github.com/babel/babel/blob/master/packages/babel-helper-plugin-test-runner/README.md
https://github.com/babel/babel/blob/master/packages/babel-helper-fixtures/README.md

(sidenote, your commit message needs [skip ci], not the pr title!)

@rajasekarm rajasekarm changed the title [skip ci] Doc changes for https://github.com/babel/babel/issues/7063 Doc changes for https://github.com/babel/babel/issues/7063 Jan 9, 2018
@rajasekarm
Copy link
Member Author

rajasekarm commented Jan 9, 2018 •
edited
Loading

@existentialism I didn't make changes in type key, https://github.com/babel/babel/blob/master/packages/babel-helper-fixtures/src/index.js#L29.

Upated the other one.

@babel-bot
Copy link
Collaborator

babel-bot commented Jan 9, 2018 •
edited
Loading

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/6547/

@existentialism existentialism merged commit f694b5d into babel:master Jan 9, 2018
@rajasekarm rajasekarm deleted the doc-changes branch January 9, 2018 17:14
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@xtuc xtuc xtuc approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Docs 📝 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test fixtures: rename actual/expected to input/output
4 participants
@rajasekarm @xtuc @existentialism @babel-bot