Spec compatibility for iteratorClose condition. #6094
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we are using just
ITERATOR_KEY.return
in the condition before we are callingiterator.return()
, but according to the spec we need to check it for abrupt completion:!_iteratorNormalCompletion && _iterator.return != null
.Spec ref:
Step 3 - https://tc39.github.io/ecma262/#sec-iteratorclose
Repl:
https://babeljs.io/repl/#?babili=false&evaluate=true&lineWrap=false&presets=es2015&targets=Node-7.3&browsers=ie%2010&builtIns=false&debug=false&code_lz=GYewTgBAFAxiB2BnALhAhhEwIFs0AcBKCAbwF8g&experimental=true&loose=false&spec=false&playground=true&stage=0