Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parens issues with exponentiation in generator #5830

Merged
merged 1 commit into from
Jun 9, 2017
Merged

Fix parens issues with exponentiation in generator #5830

merged 1 commit into from
Jun 9, 2017

Conversation

existentialism
Copy link
Member

Q A
Patch: Bug Fix? yes
Major: Breaking Change? no
Minor: New Feature? no
Deprecations? no
Spec Compliancy? no
Tests Added/Pass? yes/yes
Fixed Tickets Fixes #5829
License MIT
Doc PR
Dependency Changes

/cc: @bakkot

@existentialism existentialism added pkg: generator PR: Bug Fix 🐛 A type of pull request used for our changelog categories labels Jun 7, 2017
@codecov
Copy link

codecov bot commented Jun 7, 2017

Codecov Report

Merging #5830 into 7.0 will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              7.0    #5830      +/-   ##
==========================================
+ Coverage   85.09%   85.14%   +0.04%     
==========================================
  Files         284      284              
  Lines        9911     9916       +5     
  Branches     2768     2772       +4     
==========================================
+ Hits         8434     8443       +9     
+ Misses        976      972       -4     
  Partials      501      501
Impacted Files Coverage Δ
packages/babel-generator/src/node/parentheses.js 97% <100%> (+0.15%) ⬆️
...bel-plugin-transform-es2015-classes/src/vanilla.js 91.06% <0%> (+0.42%) ⬆️
packages/babel-traverse/src/path/context.js 86.2% <0%> (+0.86%) ⬆️
packages/babel-traverse/src/path/modification.js 73.07% <0%> (+0.96%) ⬆️
packages/babel-helper-call-delegate/src/index.js 68% <0%> (+4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cc1cbf...2f431e8. Read the comment docs.

Copy link
Member

@hzoo hzoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rauschma
Copy link

rauschma commented Jun 7, 2017

Just in case – all of these are syntax errors:

+a ** b ** c;
+(a ** b) ** c;
+a.b ** c;
+(-a) ** b;
+a ** -b;
+(a * b) ** c;
+a ** (b * c);

Source: packages/babel-generator/test/fixtures/parentheses/exponentiation/actual.js

(If these are not already negative checks then they should probably become ones.)

@hzoo
Copy link
Member

hzoo commented Jun 8, 2017

For syntax errors I believe we would just rely on the parser, don't think we need to duplicate because it would just be the same error

@existentialism
Copy link
Member Author

I'll double check the exponentiation tests in babylon (though I think most of the error cases are there)

@hzoo hzoo merged commit cce83a0 into 7.0 Jun 9, 2017
@hzoo hzoo deleted the issue5829 branch June 9, 2017 19:27
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: generator PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants